Tee video effects errors to state#2729
Merged
JamesBurnside merged 24 commits intomainfrom Feb 17, 2023
Merged
Conversation
…context when subscription events fire. Ensure this is created when unparented views are created or when the calls localvideostreams are updated
…fects-state-definitions
…-definitions' into jaburnsi/populate-video-effects-state
JamesBurnside
requested review from
PorterNan,
alkwa-msft,
anjulgarg,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
mgamis-msft and
prabhjot-msft
as code owners
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Calling bundle size is increased❗.
|
Contributor
Chat bundle size is not changed.
|
…state' into jaburnsi/tee-video-effects-errors-to-state
mgamis-msft
approved these changes
Feb 9, 2023
alkwa-msft
approved these changes
Feb 15, 2023
Base automatically changed from
jaburnsi/populate-video-effects-state
to
main
February 17, 2023 23:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When
on.(effectsErrors)fires tee this error to stateWhy
Make sure errors are propagated to state to show a message to the user
How Tested
Locally verified the callback of on effects was updating the latestErrors state:
