[BugFix BetaBlocking] Fix PSTN start Call#2739
Merged
dmceachernmsft merged 4 commits intomainfrom Feb 10, 2023
Merged
Conversation
dmceachernmsft
requested review from
alkwa-msft,
carocao-msft and
edwardlee-msft
as code owners
dmceachernmsft
requested review from
JamesBurnside,
PorterNan,
mgamis-msft and
prabhjot-msft
as code owners
Contributor
Calling bundle size is increased❗.
|
Contributor
Chat bundle size is increased❗.
|
Contributor
CallWithChat bundle size is increased❗.
|
mgamis-msft
approved these changes
Feb 10, 2023
Contributor
|
Thanks for this quick hotfix Don! Master class OCE |
edwardlee-msft
approved these changes
Feb 10, 2023
dmceachernmsft
added a commit
that referenced
this pull request
Feb 10, 2023
* update parsing function to handle phone numbers * add test for E.164 formatting * Change files * Duplicate change files for beta release
dmceachernmsft
added a commit
that referenced
this pull request
Feb 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Update
fromFlatCommunicationIdentifierfunction to handle E.164 format phone numbers as Id'sWhy
Allows for startCall handler in Adapter to parse out correct id type.
https://skype.visualstudio.com/SPOOL/_workitems/edit/3141060
How Tested
Validated calls can be connected again locally. added unit test for util function that parses id