Control bar buttons should stay centered with regard to view port width#2847
Merged
carocao-msft merged 31 commits intomainfrom Apr 1, 2023
Merged
Control bar buttons should stay centered with regard to view port width#2847carocao-msft merged 31 commits intomainfrom
carocao-msft merged 31 commits intomainfrom
Conversation
carocao-msft
requested review from
JamesBurnside,
PorterNan,
alkwa-msft,
dmceachernmsft,
edwardlee-msft,
mgamis-msft and
prabhjot-msft
as code owners
carocao-msft
requested review from
AmyL219,
Leah-Xia-Microsoft,
ShaunaSong,
jimchou-dev,
palatter,
vhuseinova-msft and
waynemo
Contributor
Calling bundle size is increased❗.
|
Contributor
Chat bundle size is decreased✅.
|
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Contributor
Contributor
|
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
carocao-msft
added
the
update_snapshots
Contributor
Contributor
carocao-msft
added
the
update_snapshots
github-actions
Bot
removed
the
update_snapshots
carocao-msft
added
the
update_snapshots
github-actions
Bot
removed
the
update_snapshots
Contributor
Contributor
Contributor
dmceachernmsft
approved these changes
Mar 31, 2023
Contributor
prabhjot-msft
approved these changes
Mar 31, 2023
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Modified callwithchat control bar styling so buttons are centered with regard to view port width
Why
https://skype.visualstudio.com/SPOOL/_workitems/edit/3183443
How Tested
callwithchat sample
tested with custom buttons
demo1.mov
To avoid call control buttons and panel control buttons overlap, at certain width we cannot center call control buttons based on viewport width anymore
So using useRef here to calculate that moment and remove the code which centers the control buttons based on viewport width
This is also why in snapshot updates you see the control bar buttons not centered to the middle, because viewport width is too small
Process & policy checklist
Is this a breaking change?