[BugFix] Hold button dismiss on mobile#2904
Merged
dmceachernmsft merged 7 commits intomainfrom Apr 11, 2023
Merged
Conversation
dmceachernmsft
requested review from
JamesBurnside,
PorterNan,
carocao-msft,
edwardlee-msft,
mgamis-msft and
prabhjot-msft
as code owners
dmceachernmsft
requested review from
a team,
AmyL219,
Leah-Xia-Microsoft,
iaulakh,
palatter,
pavelprystinka,
vhuseinova-msft and
waynemo
…/Azure/communication-ui-library into dmceachernmsft/holdbuttondismiss
Contributor
edwardlee-msft
approved these changes
Apr 10, 2023
Contributor
Contributor
Calling bundle size is increased❗.
|
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Chat bundle size is not changed.
|
Contributor
|
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
dmceachernmsft
added
the
update_snapshots
github-actions
Bot
removed
the
update_snapshots
Contributor
carocao-msft
approved these changes
Apr 11, 2023
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
screen-20230410-093222.mp4
Why
returns user to call screen after placing the call on hold
https://skype.visualstudio.com/SPOOL/_workitems/edit/3015733
How Tested
Validated locally on phone