[Bugfix] add participant count to participant list and Composite people pane#2911
Merged
dmceachernmsft merged 65 commits intomainfrom Jul 26, 2023
Merged
[Bugfix] add participant count to participant list and Composite people pane#2911dmceachernmsft merged 65 commits intomainfrom
dmceachernmsft merged 65 commits intomainfrom
Conversation
dmceachernmsft
requested review from
JamesBurnside,
PorterNan,
alkwa-msft,
carocao-msft,
edwardlee-msft,
mgamis-msft and
prabhjot-msft
as code owners
dmceachernmsft
requested review from
AmyL219,
Leah-Xia-Microsoft,
ahammer,
emlynmac,
palatter,
vhuseinova-msft and
waynemo
Contributor
Contributor
Chat bundle size is increased❗.
|
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Calling bundle size is increased❗.
|
alkwa-msft
reviewed
Apr 11, 2023
alkwa-msft
reviewed
Apr 11, 2023
alkwa-msft
reviewed
Apr 11, 2023
| "participantStateHold": "On hold" | ||
| }, | ||
| "ParticipantList": { | ||
| "overflowParticipantCount": "+{overflowCount} more" |
Contributor
There was a problem hiding this comment.
I am curious if we can review the use of "more" im unsure how its going to scale when we think of all of the other localizations
….com/Azure/communication-ui-library into dmceachernmsft/totalParticipantCount
Contributor
JamesBurnside
requested changes
Jul 19, 2023
Contributor
Contributor
Contributor
Contributor
Contributor
dmceachernmsft
added
the
update_snapshots
github-actions
Bot
removed
the
update_snapshots
Contributor
|
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
JamesBurnside
approved these changes
Jul 26, 2023
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Shows the total participant count in the participant list
https://skype.visualstudio.com/SPOOL/_workitems/edit/3124032
How Tested
Tested locally. +0 participant string is not there when normal. number is displayed participants subtracted from the total count coming from the SDK.