Teams adhoc enabled for calling handlers#2914
Merged
mgamis-msft merged 12 commits intomainfrom Apr 14, 2023
Merged
Conversation
mgamis-msft
requested review from
JamesBurnside,
PorterNan,
alkwa-msft,
carocao-msft,
dmceachernmsft,
edwardlee-msft and
prabhjot-msft
Contributor
CallWithChat bundle size is decreased✅.
|
Contributor
Calling bundle size is increased❗.
|
Contributor
Chat bundle size is decreased✅.
|
alkwa-msft
approved these changes
Apr 11, 2023
| /* @conditional-compile-remove(teams-identity-support) */ | ||
| teamsId?: string; | ||
| /* @conditional-compile-remove(teams-adhoc-call) */ | ||
| teamsIds?: string[]; |
Member
There was a problem hiding this comment.
can we call this outboundTeamsUsers or something so we know it is the identifiers that we are calling?
| /* @conditional-compile-remove(teams-identity-support) */ | ||
| const [teamsId, setTeamsId] = useState<string>(); | ||
| /* @conditional-compile-remove(teams-adhoc-call) */ | ||
| const [teamsIds, setTeamsIds] = useState<string | undefined>(); |
Member
There was a problem hiding this comment.
Can we update this like suggested above?
| <Stack> | ||
| <TextField | ||
| className={outboundTextField} | ||
| label={"Teams ID's"} |
Member
There was a problem hiding this comment.
Can we say "Teams user ID's" and maybe in the placeholder give an example since we need to prefixes to have the handlers parse correctly? or alternatively give a callout like with the alternate callerId showing an example of a good user ID to avoid confusion when others want to try it?
Contributor
Author
There was a problem hiding this comment.
Good point. Changed label and added a callout.
mgamis-msft
requested review from
JoshuaLai,
Leah-Xia-Microsoft,
emlynmac,
jpeng-ms,
palatter,
vhuseinova-msft and
waynemo
dmceachernmsft
approved these changes
Apr 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Enable Teams adhoc calling for calling handler
startCallWhy
https://skype.visualstudio.com/SPOOL/_workitems/edit/3132743
How Tested
Testing on local calling sample:
https://user-images.githubusercontent.com/79475487/231989813-5b13cb69-dc9c-4310-bc4c-b73af4a8fcbf.mp4
Process & policy checklist
Is this a breaking change?