Hide buttons based on role in Rooms call#2944
Merged
mgamis-msft merged 6 commits intomainfrom Apr 24, 2023
Merged
Conversation
mgamis-msft
requested review from
AmyL219,
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
alkwa-msft,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
Contributor
Contributor
Chat bundle size is not changed.
|
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Calling bundle size is increased❗.
|
Contributor
prabhjot-msft
approved these changes
Apr 17, 2023
dmceachernmsft
approved these changes
Apr 21, 2023
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Hide Camera, Microphone, and Screenshare buttons in rooms calls depending on role in CommonCallControlBar.
Why
https://skype.visualstudio.com/SPOOL/_workitems/edit/3229250
How Tested
Local calling sample testing:
https://user-images.githubusercontent.com/79475487/232174569-169ba6eb-5bb5-496d-a509-5aa86e98ed06.mp4
Process & policy checklist
Is this a breaking change?