[bugfix widget] Remove side pane button container when neither button enabled#2969
Merged
dmceachernmsft merged 12 commits intomainfrom May 9, 2023
Merged
Conversation
dmceachernmsft
requested review from
AmyL219,
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
alkwa-msft,
carocao-msft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
Contributor
Chat bundle size is increased❗.
|
Contributor
Calling bundle size is increased❗.
|
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Contributor
|
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
Contributor
Contributor
Contributor
Contributor
edwardlee-msft
approved these changes
Apr 27, 2023
Contributor
| </Stack.Item> | ||
| )} | ||
| {!props.mobileView && | ||
| (isEnabled(options.peopleButton) || |
Member
There was a problem hiding this comment.
consider making this a bool above to reduce the amount to parse here
const secondaryButtonsExist = !props.mobileView && (isEnabled(options.peopleButton) || isEnabled(options.chatButton) || customButtons['secondary'] !== undefined)
| {!props.mobileView && | ||
| (isEnabled(options.peopleButton) || | ||
| isEnabled(options.chatButton) || | ||
| /* @conditional-compile-remove(control-bar-button-injection) */ customButtons['secondary'] !== |
Member
There was a problem hiding this comment.
remove conditional compile, callwithchat uses this
JamesBurnside
approved these changes
May 8, 2023
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
removes container from control bar if both people and chat buttons are hidden in common controls.
Why
How Tested
Tested locally with widget POC app made change here too.