Captions RTL languages such as hebrew + arabic need to be right aligned#2999
Merged
carocao-msft merged 12 commits intomainfrom May 3, 2023
Merged
Captions RTL languages such as hebrew + arabic need to be right aligned#2999carocao-msft merged 12 commits intomainfrom
carocao-msft merged 12 commits intomainfrom
Conversation
carocao-msft
requested review from
AmyL219,
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
alkwa-msft,
dmceachernmsft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Chat bundle size is increased❗.
|
Contributor
Calling bundle size is increased❗.
|
Member
|
Can we make an e2e test for this? |
Contributor
carocao-msft
added
the
update_snapshots
github-actions
Bot
removed
the
update_snapshots
Contributor
Contributor
Contributor
Contributor
edwardlee-msft
approved these changes
May 2, 2023
PorterNan
approved these changes
May 3, 2023
Contributor
PorterNan
left a comment
PorterNan
left a comment
There was a problem hiding this comment.
Nice to see more hermetic tests on captions!
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Captions RTL languages such as hebrew + arabic need to be right aligned
Why
https://skype.visualstudio.com/SPOOL/_workitems/edit/3233581
How Tested
Process & policy checklist
Is this a breaking change?