[bugfix] Resolve overlap between tooltip and list of devices on mobile configuration page#3013
Merged
edwardlee-msft merged 8 commits intomainfrom May 3, 2023
Merged
Conversation
edwardlee-msft
requested review from
AmyL219,
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
alkwa-msft,
carocao-msft,
dmceachernmsft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
Contributor
Calling bundle size is increased❗.
|
Contributor
Chat bundle size is not changed.
|
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
dmceachernmsft
approved these changes
May 2, 2023
Contributor
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
edwardlee-msft
added
the
update_snapshots
github-actions
Bot
removed
the
update_snapshots
JamesBurnside
approved these changes
May 3, 2023
edwardlee-msft
added
the
update_snapshots
github-actions
Bot
removed
the
update_snapshots
Contributor
Contributor
JamesBurnside
pushed a commit
that referenced
this pull request
May 5, 2023
…e configuration page (#3013) * Disable tooltip on configuration page for mobile * Update hermetic tooltip tests to omit mobile on configuration screen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Disable tooltips on buttons ONLY on mobile configuration page
Why
Button tooltips in mobile configuration page overlaps with the list of devices.
How Tested
iOS safari using Calling sample
Process & policy checklist
Is this a breaking change?