Filter messageReceived notification in adapter by threadId#3056
Merged
Filter messageReceived notification in adapter by threadId#3056
Conversation
Contributor
Contributor
Chat bundle size is increased❗.
|
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Calling bundle size is not changed.
|
AmyL219
requested review from
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
alkwa-msft,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
Contributor
Contributor
emlynmac
approved these changes
May 16, 2023
JoshuaLai
approved these changes
May 16, 2023
Contributor
Author
|
Based on our previous discussion, we're treating this behavior update in the adapter as a bug fix. As this might require Contoso to modify their implementation code, let me know if there are any additional steps to consider during the release. cc @JoshuaLai |
Member
|
@AmyL219 lets just make a not of it. When we create the release notes for the release branch we will provide a more detailed description if need be. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Filter messageReceived notification in adapter by threadId
Why
The composite is specifically designed for single-threaded use. To avoid confusion when a user participates in multiple threads, we filter messageReceived notifications by threadId.
How Tested
Use same token in joining two different threads. Observed if the adapter only emit the event for the message specific to this chat thread
Process & policy checklist
Is this a breaking change?