[BugFix] hidden button fix next to display name#3080
Merged
dmceachernmsft merged 17 commits intomainfrom May 26, 2023
Merged
Conversation
dmceachernmsft
requested review from
AmyL219,
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
alkwa-msft,
carocao-msft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
dmceachernmsft
added
the
update_snapshots
github-actions
Bot
removed
the
update_snapshots
Contributor
Contributor
Chat bundle size is increased❗.
|
Contributor
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
Contributor
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
…/github.com/Azure/communication-ui-library into dmceachernmsft/hiddenButtonFix
dmceachernmsft
added
the
update_snapshots
github-actions
Bot
removed
the
update_snapshots
Contributor
…zure/communication-ui-library into dmceachernmsft/hiddenButtonFix
Contributor
dmceachernmsft
added
the
update_snapshots
github-actions
Bot
removed
the
update_snapshots
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
dmceachernmsft
added
the
update_snapshots
github-actions
Bot
removed
the
update_snapshots
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the padding from the button when it is hidden
Why
https://skype.visualstudio.com/SPOOL/_workitems/edit/3210879
How Tested
Ran locally in storybook and sample app to make sure it is appearing correctly and that it is still keyboard accessible.