Custom data model to allow changing display name of call queues#3148
Custom data model to allow changing display name of call queues#3148mgamis-msft merged 12 commits intomainfrom
Conversation
mgamis-msft
requested review from
AmyL219,
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
alkwa-msft,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
mgamis-msft
changed the title
CallWithChat bundle size is not changed.
|
Chat bundle size is not changed.
|
Calling bundle size is not changed.
|
| * The onFetchProfile is fetch-and-forget one time action for each user, once a user profile is updated, the value will be cached | ||
| * and would not be updated again within the lifecycle of adapter. | ||
| */ | ||
| onFetchProfile?: OnFetchProfileCallback; |
There was a problem hiding this comment.
Is this something that can be overridden for just normal users as well?
There was a problem hiding this comment.
Yes, you can override the display name for any user based on the userId.
| /* @conditional-compile-remove(teams-adhoc-call) */ | ||
| const onFetchProfile = async (userId: string, defaultProfile?: Profile): Promise<Profile | undefined> => { | ||
| // TODO: Explore using Graph API to differentiate Call queues from other Voice app bots | ||
| if (userId.startsWith('28:orgid:')) { |
There was a problem hiding this comment.
is this always true? I believe all bots use this prefix
There was a problem hiding this comment.
You are right. This prefix is not exclusive to call queues. I have not quite figured out how to use Graph API to determine a resource account for a call queue.
There was a problem hiding this comment.
Don is right, Bots use this prefix.
There was a problem hiding this comment.
actually, bots use 28: prefix. The orgid is something different. 28:orgid could be specific to call queue as they would technically be the organizer of the meeting. Can we confirm if other bots can be organizers?
There was a problem hiding this comment.
Oh this is a good point ^ I think if call queues are special and get the orgid moniker like users this might actually be good, is there someone on VoiceApps you can reach out to about this @mgamis-msft?
There was a problem hiding this comment.
The 28: prefix is actually for resource accounts in Microsoft 365. Each resource account can be assigned to a call queue or an auto attendant. But the Graph API can't know which Voice App a resource account is assigned to.
.
I will remove this code for our Calling sample but the point of this PR is now Contoso should be able to change the display name of their call queue if they know the resource account user id which they can do using Graph API.
mgamis-msft
force-pushed
the
mgamis/custom-data-model-to-change-display-name
branch
from
15bed05 to
ba28b12
Compare
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
4 participants
What
Custom data model to change display name of call queues
Why
https://skype.visualstudio.com/SPOOL/_workitems/edit/3248534
How Tested
Calling sample test
https://github.com/Azure/communication-ui-library/assets/79475487/3eb1c9a8-1bec-4a5b-9741-5001998aa104
Process & policy checklist
Is this a breaking change?