[Click to call] Resize observer fix#3192
Merged
dmceachernmsft merged 7 commits intomainfrom Jun 13, 2023
Merged
Conversation
dmceachernmsft
requested review from
AmyL219,
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
alkwa-msft,
carocao-msft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
Contributor
mgamis-msft
approved these changes
Jun 13, 2023
JamesBurnside
approved these changes
Jun 13, 2023
Contributor
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Chat bundle size is increased❗.
|
Contributor
Calling bundle size is increased❗.
|
Contributor
JamesBurnside
pushed a commit
that referenced
this pull request
Jun 13, 2023
* fix infinite loop * Change files * Duplicate change files for beta release * fix lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix issue where no persona size default would trigger a infinite loop in the
useLayoutEffectthat calculates the persona medallions size.Why
Prevents the infinite loop runtime error the resize observer would cause
https://skype.visualstudio.com/SPOOL/_workitems/edit/3301366
How Tested
Ran locally on a CRA application and webpack testing with our package