[bugfix] Fix screenshare render when changing overflow gallery page#3202
Merged
dmceachernmsft merged 11 commits intomainfrom Jun 15, 2023
Merged
[bugfix] Fix screenshare render when changing overflow gallery page#3202dmceachernmsft merged 11 commits intomainfrom
dmceachernmsft merged 11 commits intomainfrom
Conversation
dmceachernmsft
requested review from
AmyL219,
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
alkwa-msft,
carocao-msft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Chat bundle size is increased❗.
|
Contributor
Calling bundle size is increased❗.
|
Contributor
alkwa-msft
approved these changes
Jun 14, 2023
Contributor
Contributor
Contributor
Contributor
Contributor
alkwa-msft
pushed a commit
that referenced
this pull request
Jun 15, 2023
…3202) * add new handler to dispose screenshare * Change files * Duplicate change files for beta release * Change files * Duplicate change files for beta release * fix API issue * add new handlers and deperecate original dispose * fix mock
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
no.rerenderscreenshare.mp4
Introduces new handler to dispose just screen share streams for remote participants
Why
fixes issue where screen share would rerender when changing overflow gallery participant pages
https://skype.visualstudio.com/SPOOL/_workitems/edit/2641235
How Tested
Ran locally, see video