[Chat] Fix for a cursor position during message editing#3233
Merged
vhuseinova-msft merged 6 commits intomainfrom Jun 20, 2023
Merged
[Chat] Fix for a cursor position during message editing#3233vhuseinova-msft merged 6 commits intomainfrom
vhuseinova-msft merged 6 commits intomainfrom
Conversation
vhuseinova-msft
requested review from
AmyL219,
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
alkwa-msft,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft and
waynemo
Contributor
Contributor
Chat bundle size is increased❗.
|
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Calling bundle size is not changed.
|
emlynmac
approved these changes
Jun 20, 2023
palatter
reviewed
Jun 20, 2023
Contributor
Contributor
palatter
approved these changes
Jun 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
The cursor position should be set to the end of the string instead of the beggining of it when edit is started
How Tested
Storybook
Process & policy checklist
Is this a breaking change?