[bugfix][a11y][update] Associate in this call with username for React 16#3239
Merged
edwardlee-msft merged 17 commits intomainfrom Jun 21, 2023
Merged
Conversation
edwardlee-msft
requested review from
AmyL219,
JamesBurnside,
Leah-Xia-Microsoft,
PorterNan,
alkwa-msft,
carocao-msft,
dmceachernmsft,
jimchou-dev,
jpeng-ms,
mgamis-msft,
prabhjot-msft,
vhuseinova-msft and
waynemo
dmceachernmsft
approved these changes
Jun 20, 2023
Contributor
Contributor
Chat bundle size is decreased✅.
|
Contributor
Calling bundle size is decreased✅.
|
Contributor
CallWithChat bundle size is decreased✅.
|
Contributor
Contributor
Contributor
JamesBurnside
approved these changes
Jun 21, 2023
Contributor
Contributor
edwardlee-msft
deleted the
elee/bugfix-associate-in-this-call-with-username
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace useId with a custom communication react id generator to support React 16.
Why
useId is a new a hook introduced in React 18. Our 1.x.x library needs to support React 16+.
https://skype.visualstudio.com/SPOOL/_workitems/edit/3118296
How Tested
MacOs CallWithChat sample voiceover
Process & policy checklist
Is this a breaking change?