[Skip Screens] New Call Adapter JoinCall API to also allow start with video#3319
Merged
carocao-msft merged 10 commits intomainfrom Jul 10, 2023
Merged
[Skip Screens] New Call Adapter JoinCall API to also allow start with video#3319carocao-msft merged 10 commits intomainfrom
carocao-msft merged 10 commits intomainfrom
Conversation
carocao-msft
requested review from
AmyL219,
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
alkwa-msft,
dmceachernmsft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
Contributor
Contributor
Chat bundle size is not changed.
|
Contributor
Calling bundle size is increased❗.
|
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Contributor
| @@ -0,0 +1,7 @@ | |||
| { | |||
| "type": "prerelease", | |||
Member
There was a problem hiding this comment.
If we can go to GA with this then this should be marked as minor
dmceachernmsft
approved these changes
Jul 7, 2023
Contributor
edwardlee-msft
approved these changes
Jul 10, 2023
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
JoinCallWithOptions to allow start call with video and mic
Why
This is an extension from this PR #3304
Directly modifying joinCall can be a breaking change to customers
So we will need to implement a new joinCall api to allow call start with both mic and video
#Question
Do we need to mark this as beta and then stablize it?
It's mainly a copy of the existing joinCall API aside from the new prop and videoStream changes (the videoStream changes are marked as a todo item in the original joinCall API, however we cannot change it without breaking some customer's code)
How Tested
Tested with samples
Process & policy checklist
Is this a breaking change?