Add capabilities selector to disable camera, microphone and screenshare buttons appropriately#3374
Merged
mgamis-msft merged 58 commits intomainfrom Aug 1, 2023
Merged
Conversation
mgamis-msft
requested review from
JamesBurnside,
PorterNan,
alkwa-msft,
carocao-msft,
dmceachernmsft,
edwardlee-msft and
prabhjot-msft
Contributor
Calling bundle size is increased❗.
|
Contributor
Chat bundle size is decreased✅.
|
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
|
Failed to pass the component examples UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
Contributor
|
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
Contributor
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
…github.com/Azure/communication-ui-library into dmceachernmsft/remove-roleHint-permissions
…/capabilities-selector
…/capabilities-selector
…/capabilities-selector
Base automatically changed from
dmceachernmsft/remove-roleHint-permissions
to
main
July 29, 2023 00:16
Contributor
Contributor
Contributor
prabhjot-msft
approved these changes
Jul 31, 2023
mgamis-msft
force-pushed
the
mgamis/capabilities-selector
branch
from
eb02853 to
c4900e7
Compare
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add capabilities selector to disable camera, microphone and screenshare buttons appropriately
Why
https://skype.visualstudio.com/SPOOL/_workitems/edit/3337967
How Tested
Verified capabilities for roles are correct through console log
Process & policy checklist
Is this a breaking change?