Update Captions based on new sdk changes and add changeCaptionLanguage #3385
Merged
carocao-msft merged 35 commits intomainfrom Aug 24, 2023
Merged
Update Captions based on new sdk changes and add changeCaptionLanguage #3385carocao-msft merged 35 commits intomainfrom
carocao-msft merged 35 commits intomainfrom
Conversation
carocao-msft
requested review from
AmyL219,
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
alkwa-msft,
dmceachernmsft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
Signed-off-by: carocao-msft <96077406+carocao-msft@users.noreply.github.com>
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
carocao-msft
added
the
update_snapshots
github-actions
Bot
removed
the
update_snapshots
prabhjot-msft
approved these changes
Aug 23, 2023
Signed-off-by: carocao-msft <96077406+carocao-msft@users.noreply.github.com>
Contributor
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
carocao-msft
added
the
update_snapshots
github-actions
Bot
removed
the
update_snapshots
Contributor
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
Contributor
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
carocao-msft
added
the
update_snapshots
github-actions
Bot
removed
the
update_snapshots
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updated events, functions and variable names based on calling sdk changes
Cleaned up duplicate captions event registrations
Clear captions content when turn captions off
Use global spoken language state to determine show/hide captions modal
Enable new functionality change caption language
Why
How Tested
Process & policy checklist
Is this a breaking change?