Skip to content

Stablize Pinning layouts and rendering options#3394

Merged
prabhjot-msft merged 14 commits intomainfrom
prabhjot/stablizePinning
Sep 1, 2023
Merged

Stablize Pinning layouts and rendering options#3394
prabhjot-msft merged 14 commits intomainfrom
prabhjot/stablizePinning

Conversation

@prabhjot-msft
Copy link
Copy Markdown
Contributor

@prabhjot-msft prabhjot-msft commented Aug 1, 2023

What

Stablize Pinning layouts and rendering options

Why

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@prabhjot-msft prabhjot-msft requested review from a team as code owners August 1, 2023 23:43
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 1, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-ryxvduqsat.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 1, 2023

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 2, 2023 •
edited
Loading

Calling bundle size is decreased✅.

  • Current size: 6429186
  • Base size: 6429194
  • Diff size: -8

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 2, 2023 •
edited
Loading

Chat bundle size is decreased✅.

  • Current size: 2403241
  • Base size: 2403242
  • Diff size: -1

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 2, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-dhpyfstaoy.chromatic.com/

dmceachernmsft
dmceachernmsft reviewed Aug 2, 2023
View reviewed changes
Comment thread change-beta/@azure-communication-react-9a04e371-cd36-43ab-b99a-bfc55df8702f.json Outdated
@@ -0,0 +1,7 @@
{
"type": "prerelease",
Copy link
Copy Markdown
Member

@dmceachernmsft dmceachernmsft Aug 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question for the gang, if this PR is running the stabilization workflow these changelogs should be minor right? since we are updating the stable API with this update?

Copy link
Copy Markdown
Contributor Author

@prabhjot-msft prabhjot-msft Aug 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed it to minor

Comment thread common/config/babel/.babelrc.js
// Do not use in production code.
'stabilizedDemo',
// Pinned Participants
'pinned-participants'
Copy link
Copy Markdown
Member

@dmceachernmsft dmceachernmsft Aug 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we remove this from here along with all the conditional compilation flags?

Copy link
Copy Markdown
Contributor Author

@prabhjot-msft prabhjot-msft Aug 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think once stabilized we can remove the CC from pinned layouts

Comment thread packages/react-components/src/components/VideoGallery.tsx Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 25, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-weatlodhhu.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 25, 2023

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 31, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-eqrajjapxw.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 31, 2023

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@prabhjot-msft prabhjot-msft added the update_snapshots Set this label to request automated update of UI snapshots label Aug 31, 2023
@github-actions github-actions Bot removed the update_snapshots Set this label to request automated update of UI snapshots label Aug 31, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 31, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-wylmkgmkym.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 31, 2023

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 31, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-gnzarryqaz.chromatic.com/

@prabhjot-msft prabhjot-msft added the update_snapshots Set this label to request automated update of UI snapshots label Aug 31, 2023
@github-actions github-actions Bot removed the update_snapshots Set this label to request automated update of UI snapshots label Aug 31, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 1, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-lbjjmwygsy.chromatic.com/

@prabhjot-msft prabhjot-msft merged commit 8bb2ff8 into main Sep 1, 2023
@prabhjot-msft prabhjot-msft deleted the prabhjot/stablizePinning branch September 1, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgamis-msft mgamis-msft mgamis-msft approved these changes

@dmceachernmsft dmceachernmsft dmceachernmsft approved these changes

@JamesBurnside JamesBurnside Awaiting requested review from JamesBurnside JamesBurnside is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@edwardlee-msft edwardlee-msft Awaiting requested review from edwardlee-msft edwardlee-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@PorterNan PorterNan Awaiting requested review from PorterNan PorterNan is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@AmyL219 AmyL219 Awaiting requested review from AmyL219 AmyL219 is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

Assignees

@PorterNan PorterNan

@mgamis-msft mgamis-msft

@dmceachernmsft dmceachernmsft

Labels

breaking-change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@prabhjot-msft @mgamis-msft @dmceachernmsft @PorterNan
⚡