Capabilities change notification bar#3475
Merged
mgamis-msft merged 42 commits intomainfrom Aug 29, 2023
Merged
Conversation
mgamis-msft
requested review from
AmyL219,
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
alkwa-msft,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
and removed request for
a team
Contributor
Contributor
Contributor
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
1 similar comment
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
Contributor
…ally present capability changed notifications
Contributor
Contributor
Contributor
Contributor
edwardlee-msft
approved these changes
Aug 29, 2023
Contributor
Contributor
prabhjot-msft
approved these changes
Aug 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Show a notification bar when capabilities change
Why
https://skype.visualstudio.com/SPOOL/_workitems/edit/3360665
How Tested
Tested on local CallWIthChat sample in a Teams interop call in video below. There is also another Teams user getting notifications in the same call for comparison.
https://github.com/Azure/communication-ui-library/assets/79475487/e1dd8242-dbca-4f39-bc2b-46fdb1ee0c79
Process & policy checklist
Is this a breaking change?