Skip to content

GA raise hand#3548

Merged
mgamis-msft merged 11 commits intomainfrom
mgamis/GA-raise-hand
Sep 6, 2023
Merged

GA raise hand#3548
mgamis-msft merged 11 commits intomainfrom
mgamis/GA-raise-hand

Conversation

@mgamis-msft
Copy link
Copy Markdown
Contributor

What

StabilizingrRaise hand feature for GA

Why

For September stable release

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 2, 2023

CallWithChat bundle size is increased❗.

  • Current size: 7119258
  • Base size: 7119257
  • Diff size: 1

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 2, 2023

Chat bundle size is increased❗.

  • Current size: 2439886
  • Base size: 2439885
  • Diff size: 1

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 2, 2023

Calling bundle size is increased❗.

  • Current size: 6465899
  • Base size: 6465898
  • Diff size: 1

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 2, 2023

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 2, 2023

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@mgamis-msft mgamis-msft added breaking-change update_snapshots Set this label to request automated update of UI snapshots labels Sep 2, 2023
@github-actions github-actions Bot removed the update_snapshots Set this label to request automated update of UI snapshots label Sep 2, 2023
@mgamis-msft mgamis-msft added the update_snapshots Set this label to request automated update of UI snapshots label Sep 5, 2023
@github-actions github-actions Bot removed the update_snapshots Set this label to request automated update of UI snapshots label Sep 5, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 6, 2023

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 6, 2023

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@mgamis-msft mgamis-msft added the update_snapshots Set this label to request automated update of UI snapshots label Sep 6, 2023
@github-actions github-actions Bot removed the update_snapshots Set this label to request automated update of UI snapshots label Sep 6, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 6, 2023

@mgamis-msft
Copy link
Copy Markdown
Contributor Author

Note there are bugs in the snapshot changes like this one:
image
The new snapshot adds raise hand button in the control bar and in the more button.
This is fixed in a separate PR #3561

@mgamis-msft mgamis-msft merged commit 6f3f451 into main Sep 6, 2023
@mgamis-msft mgamis-msft deleted the mgamis/GA-raise-hand branch September 6, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants