[BugFix] Add missing composite options to CallWithChatComposite#3565
Merged
dmceachernmsft merged 7 commits intomainfrom Sep 7, 2023
Merged
[BugFix] Add missing composite options to CallWithChatComposite#3565dmceachernmsft merged 7 commits intomainfrom
dmceachernmsft merged 7 commits intomainfrom
Conversation
dmceachernmsft
requested review from
AmyL219,
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
alkwa-msft,
carocao-msft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
JamesBurnside
approved these changes
Sep 7, 2023
prabhjot-msft
approved these changes
Sep 7, 2023
…2.json Signed-off-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com>
…2.json Signed-off-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com>
Contributor
Contributor
Calling bundle size is decreased✅.
|
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Chat bundle size is decreased✅.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the missing options to CallWithChatComposite options interface:
Why
Aligns CallWithChat with CallComposite
https://skype.visualstudio.com/SPOOL/_workitems/edit/3403921
https://skype.visualstudio.com/SPOOL/_workitems/edit/3403911
Fixes #3556
How Tested
Validated locally