[bugfix] Add disableToolTip prop for ControlBarButton component#3721
Merged
edwardlee-msft merged 5 commits intomainfrom Oct 27, 2023
Merged
[bugfix] Add disableToolTip prop for ControlBarButton component#3721edwardlee-msft merged 5 commits intomainfrom
edwardlee-msft merged 5 commits intomainfrom
Conversation
edwardlee-msft
requested review from
AmyL219,
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
alkwa-msft,
carocao-msft,
dmceachernmsft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
Signed-off-by: edwardlee-msft <edwardlee@microsoft.com>
Contributor
Contributor
Calling bundle size is increased❗.
|
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Chat bundle size is not changed.
|
mgamis-msft
reviewed
Oct 26, 2023
Contributor
There was a problem hiding this comment.
Nice! Can't forget about the older child
mgamis-msft
approved these changes
Oct 26, 2023
Contributor
Contributor
@azure/communication-react jest test coverage for beta.
|
Contributor
@azure/communication-react jest test coverage for stable.
|
dmceachernmsft
approved these changes
Oct 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add disableTooltip prop for ControlBarButtons to disable tooltips as needed.
Disable tooltips on mobile for our composites.
Why
FluentUi Tooltips are persistent on the screen on mobile due to an issue with chromium not fixing sticky hover scenarios associated with this FluentUI pr microsoft/fluentui#5734.
https://skype.visualstudio.com/SPOOL/_workitems/edit/3408835
How Tested
IOS safari Call Composite and CallWithChat Composite
Process & policy checklist
Is this a breaking change?