Fix local stream rendering when screensharing#3779
Merged
mgamis-msft merged 5 commits intomainfrom Nov 9, 2023
Merged
Conversation
mgamis-msft
requested review from
JamesBurnside,
alkwa-msft,
carocao-msft,
dmceachernmsft and
edwardlee-msft
JamesBurnside
approved these changes
Nov 9, 2023
Contributor
@azure/communication-react jest test coverage for beta.
|
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Calling bundle size is increased❗.
|
Contributor
Chat bundle size is not changed.
|
dmceachernmsft
approved these changes
Nov 9, 2023
mgamis-msft
deleted the
mgamis/fix-local-stream-rendering-when-screensharing
branch
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix local video stream rendering when camera is turned on while screensharing is active.
We probably should have unit tests for stream management in the stateful client
Why
Issue was found by GroupMe and shown in this Web UI theme thread:
https://teams.microsoft.com/l/message/19:5e150d250f724d1089c949305efdc8cc@thread.skype/1699399519282?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=3e9c1fc3-39df-4486-a26a-456d80e80f82&parentMessageId=1699399519282&teamName=Azure%20Communication%20Services&channelName=Web%20UI%20-%20Team&createdTime=1699399519282
How Tested
Tested locally with 2 participants:
https://github.com/Azure/communication-ui-library/assets/79475487/f2cf202f-edef-4b71-b675-d1812ddd744a
Process & policy checklist
Is this a breaking change?