[Rooms] Fix overflow gallery to use all available space when you are a consumer#3825
Merged
mgamis-msft merged 5 commits intomainfrom Nov 23, 2023
Merged
Conversation
mgamis-msft
requested review from
AmyL219,
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
alkwa-msft,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
Contributor
Contributor
CallWithChat bundle size is decreased✅.
|
Contributor
Calling bundle size is decreased✅.
|
Contributor
Chat bundle size is not changed.
|
Contributor
@azure/communication-react jest test coverage for beta.
|
Contributor
@azure/communication-react jest test coverage for stable.
|
JamesBurnside
approved these changes
Nov 23, 2023
| onFetchTilesToRender={setIndexesToRender} | ||
| isNarrow={isNarrow} | ||
| shouldFloatLocalVideo={true} | ||
| shouldFloatLocalVideo={!!localVideoComponent} |
Member
There was a problem hiding this comment.
Is localVideoComponent valid when the video is turned off but the local video avatar shows in the floating form?
Contributor
Author
There was a problem hiding this comment.
Yup. It is valid when the local video stream is turned off.
dmceachernmsft
approved these changes
Nov 23, 2023
Contributor
Contributor
mgamis-msft
deleted the
mgamis/fix-overflow-gallery-use-all-available-space
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix logic in FloatingLocalVideoLayout and SpeakerLayout to adjust OverflowGallery to use all available space when there is no local video . Fix ScrollableHorizonalGallery to use the entire width when there is no local video.
Why
https://skype.visualstudio.com/SPOOL/_workitems/edit/3513053
How Tested
Local test app testing:
https://github.com/Azure/communication-ui-library/assets/79475487/553d1791-91d3-4707-bf32-8eef39cabfd9
Process & policy checklist
Is this a breaking change?