Skip to content

Promote rooms feature to GA#3841

Merged
mgamis-msft merged 24 commits intomainfrom
mgamis/rooms-stable
Dec 7, 2023
Merged

Promote rooms feature to GA#3841
mgamis-msft merged 24 commits intomainfrom
mgamis/rooms-stable

Conversation

@mgamis-msft
Copy link
Copy Markdown
Contributor

@mgamis-msft mgamis-msft commented Nov 29, 2023

What

Promote rooms feature to GA

Why

To get it ready for stable release in December. See if snapshots need to be updated

How Tested

Ran local sample with smoke tests.

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 29, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-tbwpfihvsi.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 4, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-efxhzkpnvq.chromatic.com/

dmceachernmsft
dmceachernmsft reviewed Dec 4, 2023
View reviewed changes
Comment thread ...PageState.test.ts-snapshots/permission-denied-to-room-page-Mobile-Android-Portrait-linux.png
Copy link
Copy Markdown
Member

@dmceachernmsft dmceachernmsft Dec 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something here seems a little out of balance. should there be more padding on the left?

Copy link
Copy Markdown
Contributor Author

@mgamis-msft mgamis-msft Dec 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah looks weird because the line breaks early on the right
image
This can be fixed in a separate PR

Comment thread ...ts-snapshots/rooms-call-screen-consumer-click-more-button-Mobile-Android-Landscape-linux.png
Copy link
Copy Markdown
Member

@dmceachernmsft dmceachernmsft Dec 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these not in the bottom sheet drawer? do we want to not use the side pane here?

Copy link
Copy Markdown
Contributor Author

@mgamis-msft mgamis-msft Dec 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rooms call screen snapshots are using the old control bar which are still using the flyout. I'm potentially working on stabilizing the people button for the old control bar but that is in a separate PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 6, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-yntumhisqe.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 6, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-veysjnynie.chromatic.com/

JamesBurnside
JamesBurnside reviewed Dec 6, 2023
View reviewed changes
Comment thread packages/communication-react/review/stable/communication-react.api.md
ParticipantItemMicOff: JSX.Element;
ParticipantItemScreenShareStart: JSX.Element;
VideoTileMicOff: JSX.Element;
NoticePageNotInvitedToRoom?: JSX.Element | undefined;
Copy link
Copy Markdown
Member

@JamesBurnside JamesBurnside Dec 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be the api extractor, but these should just have the ? and not have the | undefined

Copy link
Copy Markdown
Contributor Author

@mgamis-msft mgamis-msft Dec 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is the api extractor but at least it is consistent.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 6, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-ksojudgjww.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 6, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-dmnajtuyzz.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 7, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-pusybwmqid.chromatic.com/

@mgamis-msft mgamis-msft enabled auto-merge (squash) December 7, 2023 00:52
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 7, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-wfnkxpndcz.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 7, 2023

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 7, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-hpxewhlcii.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 7, 2023

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 7, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-eibdabxbeb.chromatic.com/

@mgamis-msft mgamis-msft merged commit bf84a9a into main Dec 7, 2023
@mgamis-msft mgamis-msft deleted the mgamis/rooms-stable branch December 7, 2023 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JamesBurnside JamesBurnside JamesBurnside approved these changes

@dmceachernmsft dmceachernmsft dmceachernmsft approved these changes

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@edwardlee-msft edwardlee-msft Awaiting requested review from edwardlee-msft edwardlee-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@PorterNan PorterNan Awaiting requested review from PorterNan PorterNan is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@AmyL219 AmyL219 Awaiting requested review from AmyL219 AmyL219 is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

Assignees

@JamesBurnside JamesBurnside

@dmceachernmsft dmceachernmsft

Labels

breaking-change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mgamis-msft @JamesBurnside @dmceachernmsft
⚡