[Chat] Add a Narrator announcement when a message is deleted #3844
Merged
vhuseinova-msft merged 17 commits intomainfrom Dec 4, 2023
Merged
[Chat] Add a Narrator announcement when a message is deleted #3844vhuseinova-msft merged 17 commits intomainfrom
vhuseinova-msft merged 17 commits intomainfrom
Conversation
vhuseinova-msft
requested review from
AmyL219,
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
alkwa-msft,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft and
waynemo
Contributor
Contributor
Chat bundle size is increased❗.
|
Contributor
Contributor
…com:Azure/communication-ui-library into vhuseinova/deleted-message-announcement-fix
Contributor
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
@azure/communication-react jest test coverage for beta.
|
Contributor
emlynmac
reviewed
Nov 30, 2023
emlynmac
approved these changes
Dec 1, 2023
…com:Azure/communication-ui-library into vhuseinova/deleted-message-announcement-fix
Contributor
Contributor
Contributor
palatter
approved these changes
Dec 4, 2023
Member
palatter
left a comment
palatter
left a comment
There was a problem hiding this comment.
Tested and looks good!
Just curious, do we have an accessibility bug having a similar announcement on a message being edited?
Member
Author
I don't thinnk we have one under the Accessibility group but we add information that message is edited for that message element |
vhuseinova-msft
deleted the
vhuseinova/deleted-message-announcement-fix
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Added an announcement when a message is deleted
Why
How Tested
Chat sample app
Process & policy checklist
Is this a breaking change?