Skip to content

[Chat] Update inline image / file sharing data type names#3846

Merged
emlynmac merged 24 commits intomainfrom
emlyn/update-inline-image-names
Dec 1, 2023
Merged

[Chat] Update inline image / file sharing data type names#3846
emlynmac merged 24 commits intomainfrom
emlyn/update-inline-image-names

Conversation

@emlynmac
Copy link
Copy Markdown
Member

@emlynmac emlynmac commented Nov 30, 2023 •
edited
Loading

What

Update naming and data layout for inline images and file attachments following internal review
ChatMessage now has files and inlineImages

Why

Simplify the API and clarify usage

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 30, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-bdoqotjxfe.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 30, 2023 •
edited
Loading

Chat bundle size is decreased✅.

  • Current size: 1522310
  • Base size: 1522451
  • Diff size: -141

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 30, 2023 •
edited
Loading

Calling bundle size is not changed.

  • Current size: 5584942
  • Base size: 5584942
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 30, 2023 •
edited
Loading

CallWithChat bundle size is decreased✅.

  • Current size: 6394225
  • Base size: 6394366
  • Diff size: -141

@emlynmac emlynmac changed the title Emlyn/update inline image names [Chat] Update inline image / file sharing data type names Nov 30, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 30, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-slxmdmxrap.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 30, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-myzrnpzxcb.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 30, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-axiagebewn.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 30, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-xsqmykvnzv.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 30, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-ktadydhtjn.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 30, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-knmisgdpra.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 30, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-rmtkdrdqwk.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 30, 2023

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 30, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-raoupuqwpm.chromatic.com/

Leah-Xia-Microsoft
Leah-Xia-Microsoft reviewed Nov 30, 2023
View reviewed changes
Comment thread packages/communication-react/review/beta/communication-react.api.md
extension: string;
id: string;
name: string;
// (undocumented)
Copy link
Copy Markdown
Member

@Leah-Xia-Microsoft Leah-Xia-Microsoft Nov 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional: Would be nice to add document of what this payload is about and what are the keys and values.

Copy link
Copy Markdown
Member Author

@emlynmac emlynmac Nov 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type is documented: https://github.com/Azure/communication-ui-library/pull/3846/files/0c588a84d91b17d2c283c66bb7bc83abfc6a1bcb#diff-d257e524dc363b5145a6b1c8b21f6f13fa9238b80aa0e665ce5505edc58ee9d9R29
I'm not sure why it's not coming through at this level with the tooling,.

@Leah-Xia-Microsoft
Copy link
Copy Markdown
Member

Leah-Xia-Microsoft commented Nov 30, 2023

In the storybook generated from this PR (https://60c7ae6891f0e90039d7cd54-zpwcqifwwg.chromatic.com/?path=/story/ui-components-messagethread--message-thread),
when sending a message with inline image in the Preview tab, the image is not displayed. Is it related to the changes in this PR?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 30, 2023

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 30, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-atytyykbji.chromatic.com/

@emlynmac
Copy link
Copy Markdown
Member Author

emlynmac commented Nov 30, 2023

In the storybook generated from this PR (https://60c7ae6891f0e90039d7cd54-zpwcqifwwg.chromatic.com/?path=/story/ui-components-messagethread--message-thread), when sending a message with inline image in the Preview tab, the image is not displayed. Is it related to the changes in this PR?

Thanks; missed a storybook change.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 30, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-bcuhplegpp.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 30, 2023

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 1, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-zmzeqdlumz.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 1, 2023

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 1, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-ftfohgsojh.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 1, 2023

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 1, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-uxhnxpceiy.chromatic.com/

palatter
palatter reviewed Dec 1, 2023
View reviewed changes
Comment thread change/@azure-communication-react-a596f1ce-68e3-45d1-b493-96bff2bdaedf.json
palatter
palatter reviewed Dec 1, 2023
View reviewed changes
Comment thread packages/communication-react/review/beta/communication-react.api.md Outdated
Leah-Xia-Microsoft
Leah-Xia-Microsoft approved these changes Dec 1, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Leah-Xia-Microsoft Leah-Xia-Microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides Patrick's comments, all look good. Thanks for the hard work.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 1, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-xewmmsicbq.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 1, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-wvuddrwtxh.chromatic.com/

@emlynmac emlynmac enabled auto-merge (squash) December 1, 2023 19:51
@emlynmac emlynmac merged commit 71f3f19 into main Dec 1, 2023
@emlynmac emlynmac deleted the emlyn/update-inline-image-names branch December 1, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoshuaLai JoshuaLai JoshuaLai left review comments

@palatter palatter palatter left review comments

@Leah-Xia-Microsoft Leah-Xia-Microsoft Leah-Xia-Microsoft approved these changes

@AmyL219 AmyL219 Awaiting requested review from AmyL219 AmyL219 is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JamesBurnside JamesBurnside Awaiting requested review from JamesBurnside JamesBurnside is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@dmceachernmsft dmceachernmsft Awaiting requested review from dmceachernmsft dmceachernmsft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@edwardlee-msft edwardlee-msft Awaiting requested review from edwardlee-msft edwardlee-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@PorterNan PorterNan Awaiting requested review from PorterNan PorterNan is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@mgamis-msft mgamis-msft Awaiting requested review from mgamis-msft mgamis-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

+1 more reviewer

@vhuseinova-msft vhuseinova-msft vhuseinova-msft approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JoshuaLai JoshuaLai

@Leah-Xia-Microsoft Leah-Xia-Microsoft

Labels

breaking-change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@emlynmac @Leah-Xia-Microsoft @JoshuaLai @palatter @vhuseinova-msft
⚡