Skip to content

Strings update before 1.11.0 release#3899

Merged
mgamis-msft merged 5 commits intomainfrom
mgamis/1.11.0-strings-update
Dec 11, 2023
Merged

Strings update before 1.11.0 release#3899
mgamis-msft merged 5 commits intomainfrom
mgamis/1.11.0-strings-update

Conversation

@mgamis-msft
Copy link
Copy Markdown
Contributor

@mgamis-msft mgamis-msft commented Dec 11, 2023

What

Update strings from TD Build cache

Why

Get ready for stable release

How Tested

No manual tests

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@mgamis-msft mgamis-msft marked this pull request as ready for review December 11, 2023 11:49
@mgamis-msft mgamis-msft requested review from a team as code owners December 11, 2023 11:49
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 11, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-teyugfiftt.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 11, 2023 •
edited
Loading

Chat bundle size is not changed.

  • Current size: 1526469
  • Base size: 1526469
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 11, 2023 •
edited
Loading

CallWithChat bundle size is not changed.

  • Current size: 6400985
  • Base size: 6400985
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 11, 2023 •
edited
Loading

Calling bundle size is not changed.

  • Current size: 5587801
  • Base size: 5587801
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 11, 2023 •
edited
Loading

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 43564 / 68816
63.3%		 43564 / 68816
63.3%		 906 / 1952
46.41%		 2587 / 4177
61.93%
Current 43566 / 68816
63.3%		 43566 / 68816
63.3%		 906 / 1952
46.41%		 2594 / 4179
62.07%
Diff 2 / 0
0%		 2 / 0
0%		 0 / 0
0%		 7 / 2
0.14%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 11, 2023 •
edited
Loading

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 21227 / 33186
63.96%		 21227 / 33186
63.96%		 579 / 1003
57.72%		 1677 / 2676
62.66%
Current 21224 / 33186
63.95%		 21224 / 33186
63.95%		 579 / 1003
57.72%		 1693 / 2685
63.05%
Diff -3 / 0
-0.01%		 -3 / 0
-0.01%		 0 / 0
0%		 16 / 9
0.39%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 11, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-qyopfrgsbs.chromatic.com/

@mgamis-msft mgamis-msft enabled auto-merge (squash) December 11, 2023 19:02
@mgamis-msft mgamis-msft merged commit c8e9082 into main Dec 11, 2023
@mgamis-msft mgamis-msft deleted the mgamis/1.11.0-strings-update branch December 11, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmceachernmsft dmceachernmsft dmceachernmsft approved these changes

@Leah-Xia-Microsoft Leah-Xia-Microsoft Leah-Xia-Microsoft approved these changes

@JamesBurnside JamesBurnside Awaiting requested review from JamesBurnside JamesBurnside is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@edwardlee-msft edwardlee-msft Awaiting requested review from edwardlee-msft edwardlee-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@PorterNan PorterNan Awaiting requested review from PorterNan PorterNan is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@AmyL219 AmyL219 Awaiting requested review from AmyL219 AmyL219 is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

Assignees

@JoshuaLai JoshuaLai

@dmceachernmsft dmceachernmsft

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mgamis-msft @dmceachernmsft @Leah-Xia-Microsoft @JoshuaLai
⚡