[BugFix] background picker remove use of after#3909
Merged
dmceachernmsft merged 14 commits intomainfrom Dec 18, 2023
Merged
Conversation
dmceachernmsft
requested review from
AmyL219,
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
alkwa-msft,
carocao-msft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
Contributor
Contributor
CallWithChat bundle size is decreased✅.
|
Contributor
Chat bundle size is not changed.
|
Contributor
Calling bundle size is decreased✅.
|
Contributor
@azure/communication-react jest test coverage for beta.
|
github-actions
Bot
removed
the
update_snapshots
Contributor
Contributor
Contributor
Contributor
|
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
Contributor
Contributor
Contributor
mgamis-msft
approved these changes
Dec 14, 2023
Contributor
Contributor
Contributor
edwardlee-msft
approved these changes
Dec 18, 2023
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the use of after in the CSS for the video effects picker items. This is used heavily by fluent and we shouldn't use this in the future
Why
Renders the background appropriately in the picker on each button no matter the state of the button
https://skype.visualstudio.com/SPOOL/_workitems/edit/3524667
How Tested
Validate locally, snapshots to come too
