Skip to content

[Bugfix] Call timeout end call screen#3914

Merged
dmceachernmsft merged 9 commits intomainfrom
dmceachernmsft/call-timeout-screen
Dec 18, 2023
Merged

[Bugfix] Call timeout end call screen#3914
dmceachernmsft merged 9 commits intomainfrom
dmceachernmsft/call-timeout-screen

Conversation

@dmceachernmsft
Copy link
Copy Markdown
Member

What

image
Introduce new end call screen for when call times out

Why

allows accurate reporting for endcall reason

https://skype.visualstudio.com/SPOOL/_workitems/edit/3518030

How Tested

Validated locally

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 14, 2023

Chat bundle size is increased❗.

  • Current size: 1533818
  • Base size: 1533620
  • Diff size: 198

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 14, 2023

Calling bundle size is increased❗.

  • Current size: 5612679
  • Base size: 5612249
  • Diff size: 430

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 14, 2023

CallWithChat bundle size is increased❗.

  • Current size: 6432594
  • Base size: 6432164
  • Diff size: 430

@github-actions
Copy link
Copy Markdown
Contributor

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 14, 2023

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 43897 / 70088
62.63%
43897 / 70088
62.63%
906 / 1970
45.98%
2613 / 4205
62.14%
Current 43888 / 70109
62.59%
43888 / 70109
62.59%
906 / 1970
45.98%
2600 / 4194
61.99%
Diff -9 / 21
-0.04%
-9 / 21
-0.04%
0 / 0
0%
-13 / -11
-0.15%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 14, 2023

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 21233 / 33752
62.9%
21233 / 33752
62.9%
579 / 1010
57.32%
1686 / 2688
62.72%
Current 21230 / 33752
62.89%
21230 / 33752
62.89%
579 / 1010
57.32%
1692 / 2691
62.87%
Diff -3 / 0
-0.01%
-3 / 0
-0.01%
0 / 0
0%
6 / 3
0.15%

@github-actions
Copy link
Copy Markdown
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

@dmceachernmsft dmceachernmsft enabled auto-merge (squash) December 18, 2023 16:51
@dmceachernmsft dmceachernmsft merged commit 89df7f1 into main Dec 18, 2023
@dmceachernmsft dmceachernmsft deleted the dmceachernmsft/call-timeout-screen branch December 18, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants