Skip to content

[Chat] New message button fix#3930

Merged
vhuseinova-msft merged 8 commits intomainfrom
vhuseinova/newMessageButton-fix
Dec 21, 2023
Merged

[Chat] New message button fix#3930
vhuseinova-msft merged 8 commits intomainfrom
vhuseinova/newMessageButton-fix

Conversation

@vhuseinova-msft
Copy link
Copy Markdown
Member

What

Fix for an issue when a new messages button was shown because the status didn't match for the same message
How to reproduce the issue on main:

  • join a chat with some messages
  • when joining chat try to scroll quickly
  • new messages button shown when it shouldn't

Why

How Tested

Sample apps

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 19, 2023

Calling bundle size is not changed.

  • Current size: 5613743
  • Base size: 5613743
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 19, 2023

Chat bundle size is increased❗.

  • Current size: 1526981
  • Base size: 1526945
  • Diff size: 36

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 19, 2023

CallWithChat bundle size is increased❗.

  • Current size: 6424348
  • Base size: 6424312
  • Diff size: 36

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 19, 2023

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 21765 / 34332
63.39%
21765 / 34332
63.39%
595 / 1028
57.87%
1728 / 2734
63.2%
Current 21763 / 34332
63.38%
21763 / 34332
63.38%
595 / 1028
57.87%
1694 / 2716
62.37%
Diff -2 / 0
-0.01%
-2 / 0
-0.01%
0 / 0
0%
-34 / -18
-0.83%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 19, 2023

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 43719 / 70145
62.32%
43719 / 70145
62.32%
906 / 1970
45.98%
2582 / 4186
61.68%
Current 43724 / 70145
62.33%
43724 / 70145
62.33%
906 / 1970
45.98%
2575 / 4183
61.55%
Diff 5 / 0
0.01%
5 / 0
0.01%
0 / 0
0%
-7 / -3
-0.13%

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

Comment thread packages/react-components/src/components/MessageThread.tsx
@github-actions
Copy link
Copy Markdown
Contributor

@vhuseinova-msft vhuseinova-msft enabled auto-merge (squash) December 21, 2023 17:10
@github-actions
Copy link
Copy Markdown
Contributor

@vhuseinova-msft vhuseinova-msft merged commit 6648036 into main Dec 21, 2023
@vhuseinova-msft vhuseinova-msft deleted the vhuseinova/newMessageButton-fix branch December 21, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants