Disable the camera button while the source is being switched#3943
Merged
JamesBurnside merged 11 commits intomainfrom Jan 3, 2024
Merged
Disable the camera button while the source is being switched#3943JamesBurnside merged 11 commits intomainfrom
JamesBurnside merged 11 commits intomainfrom
Conversation
Contributor
Contributor
JamesBurnside
requested review from
AmyL219,
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
alkwa-msft,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
Contributor
Contributor
Contributor
Calling bundle size is increased❗.
|
Contributor
Chat bundle size is decreased✅.
|
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
@azure/communication-react jest test coverage for beta.
|
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
dmceachernmsft
approved these changes
Jan 2, 2024
Contributor
edwardlee-msft
approved these changes
Jan 3, 2024
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
await stream?.getMediaStream();) while a bug is being fixed on the calling sdkWhy
Quick successive uses causes the camera to lock up
https://skype.visualstudio.com/SPOOL/_workitems/edit/3521866
How Tested
Locally, verified switching the camera disables the camera buttons until the new stream has loaded, and could no longer repro the camera locking up.