[bugfix] Hide speaker dropdown for safari browser#3964
Merged
edwardlee-msft merged 14 commits intomainfrom Jan 5, 2024
Merged
Conversation
… not available for Safari browsers
edwardlee-msft
requested review from
JamesBurnside,
alkwa-msft and
dmceachernmsft
edwardlee-msft
requested review from
AmyL219,
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
carocao-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
dmceachernmsft
approved these changes
Jan 4, 2024
Contributor
Member
|
Hmm I suppose we should remove this empty space for this scenario -- might need @pereiralex input |
…s://github.com/Azure/communication-ui-library into elee/bugfix-remove-speaker-dropdown-for-safari
Contributor
Contributor
Author
Confirmed with Alex P that we should shrink the container size. |
JamesBurnside
approved these changes
Jan 4, 2024
Member
JamesBurnside
left a comment
JamesBurnside
left a comment
There was a problem hiding this comment.
Couple suggestions - looks good though!
Contributor
Contributor
Contributor
Contributor
Contributor
Contributor
Chat bundle size is not changed.
|
Contributor
Calling bundle size is increased❗.
|
Contributor
CallWithChat bundle size is increased❗.
|
JamesBurnside
approved these changes
Jan 5, 2024
Contributor
@azure/communication-react jest test coverage for beta.
|
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
dmceachernmsft
approved these changes
Jan 5, 2024
Contributor
edwardlee-msft
deleted the
elee/bugfix-remove-speaker-dropdown-for-safari
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In configuration page, hide speaker dropdown for safari browser
Why
https://skype.visualstudio.com/SPOOL/_workitems/edit/3398753
How Tested
Locally on MacOs Safari browser. Call Composite.
Process & policy checklist
Is this a breaking change?