Add messageEdited and messagedDeleted events to ChatAdapter. Update the unread message badge when a message is deleted.#3971
Merged
JamesBurnside merged 10 commits intomainfrom Jan 5, 2024
Conversation
…these events to update the unread message badge in the callwithchat composite when a message is deleted
JamesBurnside
commented
Jan 5, 2024
Contributor
Chat bundle size is increased❗.
|
Contributor
Calling bundle size is not changed.
|
Contributor
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
|
Failed to pass the component examples UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
@azure/communication-react jest test coverage for beta.
|
Contributor
JamesBurnside
requested review from
PorterNan,
alkwa-msft,
carocao-msft,
dmceachernmsft and
edwardlee-msft
JamesBurnside
requested review from
AmyL219,
JoshuaLai,
Leah-Xia-Microsoft,
emlynmac,
jimchou-dev,
jpeng-ms,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
Member
Author
|
Added breaking-change label as the breaking change is adding new string literals to the |
…ng fields in the ChatMessage fields of deletedOn and editedOn
Contributor
Contributor
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
vhuseinova-msft
approved these changes
Jan 5, 2024
dmceachernmsft
approved these changes
Jan 5, 2024
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Unread messages badge should update when an unread chat message is deleted.
How Tested
Verified locally deleting a chat messages decrements the unread message count to other participants in the callwithchat