[DTMF Dialer] introduce dialpad to composite#4041
Merged
dmceachernmsft merged 11 commits intomainfrom Jan 23, 2024
Merged
Conversation
dmceachernmsft
requested review from
AmyL219,
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
alkwa-msft,
carocao-msft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
Contributor
Contributor
Contributor
Contributor
Calling bundle size is increased❗.
|
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Chat bundle size is increased❗.
|
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
@azure/communication-react jest test coverage for beta.
|
Contributor
|
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
edwardlee-msft
approved these changes
Jan 22, 2024
dmceachernmsft
added
the
update_snapshots
github-actions
Bot
removed
the
update_snapshots
Contributor
…/Azure/communication-ui-library into dmceachernmsft/dialpad-composite
Contributor
mgamis-msft
approved these changes
Jan 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Introduces the dialpad to the call composite through a button on the control bar
Why
Allows for sending of DTMF tones in a call
https://skype.visualstudio.com/SPOOL/_workitems/edit/3564631
How Tested
Tested locally
There are more PR's to come:
dtmfmode anddialermode for OPS