[DTMF Dialer] remove old dtmf experience and update long press#4065
Merged
dmceachernmsft merged 18 commits intomainfrom Jan 27, 2024
Merged
[DTMF Dialer] remove old dtmf experience and update long press#4065dmceachernmsft merged 18 commits intomainfrom
dmceachernmsft merged 18 commits intomainfrom
Conversation
dmceachernmsft
requested review from
AmyL219,
JamesBurnside,
Leah-Xia-Microsoft,
PorterNan,
alkwa-msft,
carocao-msft,
edwardlee-msft,
jimchou-dev,
jpeng-ms,
mgamis-msft,
prabhjot-msft and
vhuseinova-msft
dmceachernmsft
requested review from
JoshuaLai,
emlynmac,
palatter and
waynemo
dmceachernmsft
changed the base branch from
main
to
dmceachernmsft/call-timer-reset
Contributor
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
JamesBurnside
approved these changes
Jan 26, 2024
Member
JamesBurnside
left a comment
JamesBurnside
left a comment
There was a problem hiding this comment.
API naming suggestion, otherwise looks great!
Contributor
mgamis-msft
approved these changes
Jan 26, 2024
Contributor
Contributor
@azure/communication-react jest test coverage for beta.
|
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
Contributor
Contributor
Chat bundle size is not changed.
|
Contributor
CallWithChat bundle size is decreased✅.
|
Contributor
Calling bundle size is decreased✅.
|
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR Updates the isMobile Property on the dialpad to be a new property
longpressTriggerto indicate what the on click or touch behaviour should beWhy
The API before was tracking the mode of mobile and this is something that we consider only in the composite package. this will allow contoso to appropriately determine which kind of dialpad that they would like to use for their devices
Bugs and API changes
How Tested
Tested and built locally