Skip to content

[DTMF Dialer] Dialpad back button overlap fix#4079

Merged
dmceachernmsft merged 4 commits intomainfrom
dmceachernmsft/dialpad-back-button-fix
Jan 31, 2024
Merged

[DTMF Dialer] Dialpad back button overlap fix#4079
dmceachernmsft merged 4 commits intomainfrom
dmceachernmsft/dialpad-back-button-fix

Conversation

@dmceachernmsft
Copy link
Copy Markdown
Member

What

Fix issue where back button over laps dialed number

Why

allows for even spacing between button and phone number entered

https://skype.visualstudio.com/SPOOL/_workitems/edit/3588391

How Tested

image
Validated locally

Comment thread packages/react-components/src/components/styles/Dialpad.styles.ts Outdated
@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 31, 2024

Calling bundle size is increased❗.

  • Current size: 5738541
  • Base size: 5738489
  • Diff size: 52

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 31, 2024

CallWithChat bundle size is increased❗.

  • Current size: 6464077
  • Base size: 6464025
  • Diff size: 52

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 31, 2024

Chat bundle size is not changed.

  • Current size: 1445660
  • Base size: 1445660
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 31, 2024

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 21414 / 34133
62.73%
21414 / 34133
62.73%
580 / 1026
56.53%
1694 / 2698
62.78%
Current 45134 / 73241
61.62%
45134 / 73241
61.62%
921 / 2048
44.97%
2609 / 4276
61.01%
Diff 23720 / 39108
-1.11%
23720 / 39108
-1.11%
341 / 1022
-11.56%
915 / 1578
-1.77%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 31, 2024

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 44648 / 71951
62.05%
44648 / 71951
62.05%
913 / 2019
45.22%
2631 / 4244
61.99%
Current 45134 / 73241
61.62%
45134 / 73241
61.62%
921 / 2048
44.97%
2609 / 4276
61.01%
Diff 486 / 1290
-0.43%
486 / 1290
-0.43%
8 / 29
-0.25%
-22 / 32
-0.98%

@github-actions
Copy link
Copy Markdown
Contributor

@dmceachernmsft dmceachernmsft merged commit 44946d7 into main Jan 31, 2024
@dmceachernmsft dmceachernmsft deleted the dmceachernmsft/dialpad-back-button-fix branch January 31, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants