[Chat] Wrap ImageOverlay with theme provider and change some of the APIs#4117
Merged
Leah-Xia-Microsoft merged 16 commits intomainfrom Feb 9, 2024
Merged
Conversation
Leah-Xia-Microsoft
requested review from
AmyL219,
JamesBurnside,
JoshuaLai,
PorterNan,
alkwa-msft,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
Contributor
Contributor
Contributor
emlynmac
reviewed
Feb 9, 2024
Member
There was a problem hiding this comment.
It looks like the test images are no longer on a black overlay background; is this intended?
Leah-Xia-Microsoft
added
the
update_snapshots
github-actions
Bot
removed
the
update_snapshots
Contributor
Contributor
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
Contributor
Leah-Xia-Microsoft
added
the
update_snapshots
github-actions
Bot
removed
the
update_snapshots
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
Leah-Xia-Microsoft
added
update_snapshots
github-actions
Bot
removed
update_chat_snapshots
update_snapshots
Contributor
Contributor
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
…github.com/Azure/communication-ui-library into leahxia/WrapImageOverlayWithAThemeProvider
Contributor
emlynmac
approved these changes
Feb 9, 2024
Leah-Xia-Microsoft
deleted the
leahxia/WrapImageOverlayWithAThemeProvider
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
How Tested
Process & policy checklist
Is this a breaking change?