Skip to content

[Chat] Fix for "The messsage is deleted" accessibility announcement#4169

Merged
vhuseinova-msft merged 13 commits intomainfrom
john/voiceover-fix
Feb 23, 2024
Merged

[Chat] Fix for "The messsage is deleted" accessibility announcement#4169
vhuseinova-msft merged 13 commits intomainfrom
john/voiceover-fix

Conversation

@vhuseinova-msft
Copy link
Copy Markdown
Member

What

  • fixed an issue with message indicator icon which has status role
  • added should Announce prop for a message indicator used in MessageThread
  • most of the code is just moved around

Steps to test:
1.

  • send a few messages
  • delete messages one by one
  • check "The message is deleted" announcement
  • send a message
  • delete the message
  • check "The message is deleted" announcement

Why

How Tested

Chat sample

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 22, 2024

Calling bundle size is not changed.

  • Current size: 4964041
  • Base size: 4964041
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 22, 2024

Chat bundle size is increased❗.

  • Current size: 1455859
  • Base size: 1455604
  • Diff size: 255

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 22, 2024

CallWithChat bundle size is increased❗.

  • Current size: 5693926
  • Base size: 5693665
  • Diff size: 261

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 22, 2024

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 46581 / 75450
61.73%
46581 / 75450
61.73%
950 / 2116
44.89%
2677 / 4397
60.88%
Current 46691 / 75586
61.77%
46691 / 75586
61.77%
953 / 2119
44.97%
2697 / 4415
61.08%
Diff 110 / 136
0.04%
110 / 136
0.04%
3 / 3
0.08%
20 / 18
0.2%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 22, 2024

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 46594 / 75450
61.75%
46594 / 75450
61.75%
950 / 2116
44.89%
2681 / 4403
60.89%
Current 46698 / 75586
61.78%
46698 / 75586
61.78%
953 / 2119
44.97%
2709 / 4423
61.24%
Diff 104 / 136
0.03%
104 / 136
0.03%
3 / 3
0.08%
28 / 20
0.35%

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

@vhuseinova-msft vhuseinova-msft merged commit 9a52f9c into main Feb 23, 2024
@vhuseinova-msft vhuseinova-msft deleted the john/voiceover-fix branch February 23, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants