[Chat] Fixed Image Placeholder Being Shown When Fetching Failed#4172
Merged
[Chat] Fixed Image Placeholder Being Shown When Fetching Failed#4172
Conversation
jpeng-ms
requested review from
AmyL219,
JoshuaLai,
Leah-Xia-Microsoft,
emlynmac,
jimchou-dev,
palatter,
vhuseinova-msft and
waynemo
jpeng-ms
assigned
vhuseinova-msft,
Leah-Xia-Microsoft,
emlynmac,
jimchou-dev and
palatter
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Chat bundle size is increased❗.
|
Contributor
Calling bundle size is not changed.
|
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
@azure/communication-react jest test coverage for beta.
|
emlynmac
reviewed
Feb 23, 2024
vhuseinova-msft
approved these changes
Feb 23, 2024
emlynmac
reviewed
Feb 23, 2024
emlynmac
approved these changes
Feb 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
when internet is down or backend failed to return us an image, the image placeholder being shown to Contoso instead of the broken image icon.
This PR addresses this issue so that if image fetching is failed, we can show broken image to Contoso.
Testing for image preview
video1.mov
Testing for image gallery
video2.mov
Why
improve user experience
How Tested
Process & policy checklist
Is this a breaking change?