[Chat] Render Non ACS images without the onClick function#4214
Merged
Leah-Xia-Microsoft merged 22 commits intomainfrom Mar 5, 2024
Merged
[Chat] Render Non ACS images without the onClick function#4214Leah-Xia-Microsoft merged 22 commits intomainfrom
Leah-Xia-Microsoft merged 22 commits intomainfrom
Conversation
Leah-Xia-Microsoft
requested review from
JamesBurnside,
PorterNan,
alkwa-msft,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
mgamis-msft and
prabhjot-msft
and removed request for
a team
Leah-Xia-Microsoft
requested review from
JoshuaLai,
emlynmac,
jpeng-ms,
palatter and
waynemo
and removed request for
a team
Contributor
Chat bundle size is increased❗.
|
Contributor
Calling bundle size is increased❗.
|
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
…m/Azure/communication-ui-library into feature/removeInlineImageMetadata
Contributor
@azure/communication-react jest test coverage for beta.
|
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
emlynmac
approved these changes
Mar 5, 2024
Contributor
JoshuaLai
approved these changes
Mar 5, 2024
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In the chat composite, if the message contains image that's not an ACS image, we will render the image but it will not be clickable to view and download in the ImageOverlay
Screen.Recording.2024-03-04.at.14.39.39.mov
Why
How Tested
Process & policy checklist
Is this a breaking change?