[Chat] Remove AttachmentMetadata#4217
Merged
Leah-Xia-Microsoft merged 31 commits intomainfrom Mar 6, 2024
Merged
Conversation
…m/Azure/communication-ui-library into feature/removeInlineImageMetadata
Leah-Xia-Microsoft
requested review from
AmyL219,
jimchou-dev,
jpeng-ms and
vhuseinova-msft
and removed request for
a team
Contributor
Contributor
Contributor
Contributor
Contributor
jpeng-ms
reviewed
Mar 5, 2024
| const isShowDownloadIcon = useCallback((attachment: AttachmentMetadata): boolean => { | ||
| /* @conditional-compile-remove(file-sharing) */ | ||
| return attachment.attachmentType === 'file' && attachment.payload?.teamsFileAttachment !== 'true'; | ||
| return attachment.payload?.teamsFileAttachment !== 'true'; |
| export interface AttachmentMetadata { | ||
| extension: string; | ||
| name: string; | ||
| url: string; |
Member
There was a problem hiding this comment.
how about id, payload ? are these 2 never GA-ed?
Member
Author
There was a problem hiding this comment.
how about
id,payload? are these 2 never GA-ed?
Yes id and payload is under the feature flag while the rest somehow was released to GA.
Member
Author
There was a problem hiding this comment.
how about
id,payload? are these 2 never GA-ed?
Actually this is the react components api view not the react communication one.
emlynmac
reviewed
Mar 6, 2024
emlynmac
approved these changes
Mar 6, 2024
Contributor
…m/Azure/communication-ui-library into leahxia/remove-AttachmentMetadata
Contributor
Contributor
jpeng-ms
approved these changes
Mar 6, 2024
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove AttachmentMetadata and directly use FileMetadata instead.
Why
How Tested
Process & policy checklist
Is this a breaking change?