[Chat] Update stateful client to return an empty string in failure cases#4230
Merged
[Chat] Update stateful client to return an empty string in failure cases#4230
Conversation
JoshuaLai
requested review from
AmyL219,
Leah-Xia-Microsoft,
emlynmac,
jimchou-dev,
jpeng-ms,
palatter,
vhuseinova-msft and
waynemo
Contributor
Calling bundle size is not changed.
|
Contributor
CallWithChat bundle size is decreased✅.
|
Contributor
Chat bundle size is decreased✅.
|
emlynmac
reviewed
Mar 7, 2024
emlynmac
approved these changes
Mar 7, 2024
Contributor
@azure/communication-react jest test coverage for beta.
|
Contributor
@azure/communication-react jest test coverage for stable.
|
palatter
reviewed
Mar 7, 2024
palatter
approved these changes
Mar 7, 2024
Member
palatter
left a comment
palatter
left a comment
There was a problem hiding this comment.
Looks good, one small comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When downloading resources the stateful client will return an empty string
The selectors will now be responsible for reading the error object in the result and manipulate the html tags appropriatly
Why
No more needing to default the stateful client to return a src url that is not correct.
Process & policy checklist
Is this a breaking change?