[Chat] Verify the fetch endpoints match#4251
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| editedMessage.content = { message: 'edited message', attachments: secondAttachments }; | ||
|
|
||
| const queue = new ResourceDownloadQueue(context, tokenCredential); | ||
| const queue = new ResourceDownloadQueue(context, { credential: tokenCredential, endpoint: 'endpoint' }); |
There was a problem hiding this comment.
This is a test file, so we kind of have magic text everywhere. Should we just refactor the whole test file?
There was a problem hiding this comment.
Extracting this to a const value doesn't seem like much.
CallWithChat bundle size is increased❗.
|
Calling bundle size is not changed.
|
Chat bundle size is increased❗.
|
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
1 similar comment
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
JoshuaLai
requested review from
AmyL219,
Leah-Xia-Microsoft,
emlynmac,
jimchou-dev,
jpeng-ms,
palatter,
vhuseinova-msft and
waynemo
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
1 similar comment
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
@azure/communication-react jest test coverage for stable.
|
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
1 similar comment
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
5 participants
What
Verify the endpoints match before making the call
Why
Adding security to the fetch call to not pass the token into a call sourced from a different endpoint.
How Tested
Running call with chat scenario all inline images should work as expected
Process & policy checklist
Is this a breaking change?