[bugfix] local recording notification initialize only in teams interop#4321
Merged
edwardlee-msft merged 4 commits intomainfrom Mar 22, 2024
Conversation
edwardlee-msft
requested review from
JamesBurnside,
PorterNan,
alkwa-msft,
carocao-msft,
dmceachernmsft,
mgamis-msft and
prabhjot-msft
…alize-only-in-teams-interop
Contributor
Chat bundle size is not changed.
|
Contributor
Calling bundle size is increased❗.
|
Contributor
CallWithChat bundle size is increased❗.
|
prabhjot-msft
approved these changes
Mar 22, 2024
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
@azure/communication-react jest test coverage for beta.
|
dmceachernmsft
approved these changes
Mar 22, 2024
edwardlee-msft
deleted the
elee/bugfix-localRecordingNotification-initialize-only-in-teams-interop
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Initialize and subscribe to local recording only once call is connected and a teams interop call
Why
Calling sdk dependency emits error when local recording is initialized not in a teams interop call.
Cause our acs samples and selfhost to experience debug errors.
How Tested
MacOS calling sample
Process & policy checklist
Is this a breaking change?