Update fluent and type-fest dependencies to latest#4347
Merged
JamesBurnside merged 10 commits intomainfrom Apr 1, 2024
Merged
Conversation
JamesBurnside
requested review from
AmyL219,
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
alkwa-msft,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
Contributor
Contributor
CallWithChat bundle size is decreased✅.
|
Contributor
Chat bundle size is decreased✅.
|
Contributor
Calling bundle size is increased❗.
|
edwardlee-msft
approved these changes
Mar 27, 2024
Contributor
Contributor
@azure/communication-react jest test coverage for beta.
|
Contributor
@azure/communication-react jest test coverage for stable.
|
alkwa-msft
approved these changes
Mar 28, 2024
Contributor
JoshuaLai
approved these changes
Apr 1, 2024
palatter
approved these changes
Apr 1, 2024
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
@fluentdependencies to latesttype-festto latestWhy
Our library currently does not build with typescript 5.3.3+. We don't see this issue because we have
skipLibCheck: truein our tsconfig. These dependency upgrades have fixes for this, notably: microsoft/fluentui#30809After this our library will still not build if typescript 4.8+ and react v18 are set due to: microsoft/fluentui#29578
Once this bug is resolved, in our CI we can set
skipLibCheck: falseto ensure we have test coverage on future typescript versions.How Tested
Verified turning off skipLibCheck fixed most errors (only the known issue linked above remains). Otherwise verification through CI only.