[Chat] Announce File Attachments in New Messages#4438
Merged
Conversation
jpeng-ms
requested review from
AmyL219,
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
alkwa-msft,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
emlynmac,
jimchou-dev,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
Contributor
Contributor
Contributor
CallWithChat bundle size is increased❗.
|
Contributor
Calling bundle size is increased❗.
|
Contributor
Chat bundle size is increased❗.
|
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
@azure/communication-react jest test coverage for beta.
|
jimchou-dev
reviewed
Apr 9, 2024
emlynmac
reviewed
Apr 9, 2024
| if (props.message.content || attachments) { | ||
| // Replace all <img> tags with 'image' for aria. | ||
| const parsedContent = DOMPurify.sanitize(props.message.content, { | ||
| const parsedContent = DOMPurify.sanitize(props.message.content ?? '', { |
Member
There was a problem hiding this comment.
It looks like sanitize can take undefined?
Member
Author
There was a problem hiding this comment.
it doesn't, it takes string | Node
Contributor
| /* @conditional-compile-remove(mention) */ | ||
| import { defaultOnMentionRender } from './MentionRenderer'; | ||
| import DOMPurify from 'dompurify'; | ||
| import { _AttachmentDownloadCardsStrings } from '../AttachmentDownloadCards'; |
Member
There was a problem hiding this comment.
Not necessarily related to this PR but for @JoshuaLai to confirm, do we still need the type of _AttachmentDownloadCardsStrings and the function of useLocaleStringsTrampoline?
Leah-Xia-Microsoft
approved these changes
Apr 9, 2024
Contributor
Leah-Xia-Microsoft
approved these changes
Apr 9, 2024
jimchou-dev
approved these changes
Apr 9, 2024
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixed the issue where live messages don't announce file attachments
Why
A11Y bug fix
How Tested
there are 3 scenarios:
Process & policy checklist
Is this a breaking change?